[
https://issues.apache.org/jira/browse/HDDS-1192?focusedWorklogId=229048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229048
]
ASF GitHub Bot logged work on HDDS-1192:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 11:59
Start Date: 17/Apr/19 11:59
Worklog Time Spent: 10m
Work Description: elek commented on pull request #713: HDDS-1192. Support
-conf command line argument in GenericCli
URL: https://github.com/apache/hadoop/pull/713#discussion_r276197404
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/cli/GenericCli.java
##########
@@ -70,19 +75,33 @@ protected void printError(Throwable error) {
} else {
System.err.println(error.getMessage().split("\n")[0]);
}
- if(error instanceof MissingSubcommandException){
- System.err.println(((MissingSubcommandException) error).getUsage());
- }
}
@Override
public Void call() throws Exception {
- throw new MissingSubcommandException(cmd.getUsageMessage());
Review comment:
LIKE. Thanks to fix this part (and the similar items). It's better to use
the included CommandLine.ParameterException...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 229048)
Time Spent: 1.5h (was: 1h 20m)
> Support -conf command line argument in GenericCli
> -------------------------------------------------
>
> Key: HDDS-1192
> URL: https://issues.apache.org/jira/browse/HDDS-1192
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Kitti Nanasi
> Priority: Major
> Labels: newbie, pull-request-available
> Attachments: HDDS-1192.001.patch, HDDS-1192.002.patch,
> HDDS-1192.003.patch, HDDS-1192.004.patch, HDDS-1192.005.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> org.apache.hadoop.hdds.GenericCli is the based class for all the Ozone
> related command line application. It supports to define custom configuration
> variables (-D or --set) but doesn't support the '--conf ozone-site.xml'
> argument to load an external xml file to the configuration.
> Configuration and OzoneConfiguration classes load the ozone-site.xml from the
> classpath. But it makes very hard to start Ozone components in IDE as we
> can't modify the classpath easily.
> One option here is to support the --conf everywhere to make it possible to
> start ozone cluster in the IDE.
> Note: It's a nice to have for 0.4.0. I marked it as 0.5.0 but safe to commit
> at anytime to 0.4.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
