[ https://issues.apache.org/jira/browse/HDFS-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820994#comment-16820994 ]
Ayush Saxena commented on HDFS-14431: ------------------------------------- Thanx [~elgoiri] for the patch. I guess this the first approach we discussed at HDFS-14117. Overall functionality, seems fair. * One minor stuff : can we change this name from \{{NotAllowedRenameException}} to \{{RenameNotAllowedException}} . Usually in exception names the action comes after FileNotFound, here NotFound is After. DSQuotaExceededException here Exceeded is after. * Secondly, Why are we holding up the FNF Exception in Rename API and returning false, why aren't allowing it surface, Was it handled separately somewhere? * Rename.NONE can be used instead typecasting null to rename options. > RBF: Rename with multiple subclusters should fail if no eligible locations > -------------------------------------------------------------------------- > > Key: HDFS-14431 > URL: https://issues.apache.org/jira/browse/HDFS-14431 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Íñigo Goiri > Assignee: Íñigo Goiri > Priority: Major > Attachments: HDFS-14431-HDFS-13891.001.patch, > HDFS-14431-HDFS-13891.002.patch, HDFS-14431-HDFS-13891.003.patch > > > Currently, the rename will fail with FileNotFoundException which is not clear > to the user. > The operation should fail stating the reason is that there are no eligible > destinations. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org