[
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122082#comment-13122082
]
Todd Lipcon commented on HDFS-2181:
-----------------------------------
- The javadoc for closeConnectionToNamenode has some strange
formatting/indentation. Small typo: "orcreated"
- Can you use IOUtils.closeStream there? Or at least log the exception if
there's a problem.
- Can we rename ClientDatanodeProtocolTranslator to
R23ClientDatanodeProtocolTranslator, etc?
- "Until version 69, this class ClientProtocol servers as both" has an extra
space between "Until" and "version", and should be "serves as both" not
"servers as both"
- in AdminStates.fromValue, if the value isn't in the enum, returning NORMAL
seems incorrect - maybe it should throw an exception or return a new UNKNOWN
value?
- the class name ClientNamenodeProtocolWritable implies that this class is a
writable, when in fact it's an interface... maybe rename to
ClientNamenodeWritableWireProtocol? or just ClientNamenodeWireProtocol?
Elsewhere we have the strong convention that *Writable implements Writable
after fixing those, +1 from me
> Seperate HDFS wire protocol data types
> --------------------------------------
>
> Key: HDFS-2181
> URL: https://issues.apache.org/jira/browse/HDFS-2181
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: separateDataType1.patch, separateDataType10.patch,
> separateDataType11.patch, separateDataType12.patch, separateDataType13.patch,
> separateDataType14.patch, separateDataType16.patch, separateDataType19.patch,
> separateDataType2.patch, separateDataType6.patch, separateDataType7.patch,
> separateDataType8.patch, separateDataType9.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
