[
https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822258#comment-16822258
]
Chao Sun commented on HDFS-14406:
---------------------------------
Thanks [~xuel1] for the update. Instead of adding a new class
{{RpcUserMetrics}}, can we just reuse the {{RpcDetailedMetrics}} by adding a
flag to it?
{code}
public void addProcessingTime(String name, int processingTime) {
String prefix = name;
if (this.userMetricsEnabled) {
UserGroupInformation ugi = Server.getRemoteUser();
String userName = ugi == null ? "null" : ugi.getUserName();
prefix = prefix + "-" + username;
}
rates.add(prefix, processingTime);
}
{code}
Then you only need to keep one instance of {{RpcDetailedMetrics}} in
{{Server}}, and code will look cleaner.
> Add per user RPC Processing time
> --------------------------------
>
> Key: HDFS-14406
> URL: https://issues.apache.org/jira/browse/HDFS-14406
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Xue Liu
> Assignee: Xue Liu
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HDFS-14406.001.patch, HDFS-14406.002.patch,
> HDFS-14406.003.patch, HDFS-14406.004.patch, HDFS-14406.005.patch,
> HDFS-14406.006.patch
>
>
> For a shared cluster we would want to separate users' resources, as well as
> having our metrics reflecting on the usage, latency, etc, for each user.
> This JIRA aims to add per user RPC processing time metrics and expose it via
> JMX.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
