[
https://issues.apache.org/jira/browse/HDFS-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824092#comment-16824092
]
Sammi Chen commented on HDFS-14356:
-----------------------------------
Thanks [~PhiloHe] 's effort. Some initial comments,
1. Use constants or enum for pmdk status
{code:java}
+ /* Denotes the state of supporting PMDK:
+ < 0, native code build without PMDK support
+ > 0, supported by native code, but PMDK dynamic library NOT found in
+ execution environment or failed to be loaded
+ ==0, ready for use, supported by native code, and PMDK library
+ loaded successfully
+ The value is set by JNI. */
{code}
2 . Is there potential buffer overflow risk here?
{code:java}
char msg[1000];
{code}
3. Do you plan to support Windows in this patch? If not, please clarify the
supported platform in the title or in the description. Also make sure when
compile native is enabled(-Pnative), following two cases pass
* Linux platform, compile with and without PMDK enabled
* Windows platform, compile without PMDK enabled
> Implement HDFS cache on SCM with native PMDK libs
> -------------------------------------------------
>
> Key: HDFS-14356
> URL: https://issues.apache.org/jira/browse/HDFS-14356
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching, datanode
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Attachments: HDFS-14356.000.patch, HDFS-14356.001.patch
>
>
> In this implementation, native PMDK libs are involved in mapping HDFS blocks
> to SCM. To use this implementation, user should build hadoop with PMDK libs
> by specifying a build option.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
