[
https://issues.apache.org/jira/browse/HDDS-1469?focusedWorklogId=233064&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233064
]
ASF GitHub Bot logged work on HDDS-1469:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/19 19:34
Start Date: 25/Apr/19 19:34
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #773: HDDS-1469.
Generate default configuration fragments based on annotations
URL: https://github.com/apache/hadoop/pull/773#discussion_r278699642
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
##########
@@ -754,4 +747,64 @@ private InflightAction(final DatanodeDetails datanode,
this.time = time;
}
}
+
+ /**
+ * Configuration used by the Replication Manager.
+ */
+ @ConfigGroup(prefix = "hdds.scm.replication")
+ public static class ReplicationManagerConfiguration {
+ /**
+ * The frequency in which ReplicationMonitor thread should run.
+ */
+ private long interval = 5 * 60 * 1000;
+
+ /**
+ * Timeout for container replication & deletion command issued by
+ * ReplicationManager.
+ */
+ private long eventTimeout = 10 * 60 * 1000;
+
+ @Config(key = "thread.interval",
+ type = ConfigType.TIME,
+ defaultValue = "3s",
+ tags = {SCM, OZONE},
+ description = "When a heartbeat from the data node arrives on SCM, "
+ + "It is queued for processing with the time stamp of when the "
Review comment:
@nandakumar131 Do we still use this Key ? or is this some code changed but
we forgot to remove the config value case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 233064)
Time Spent: 1.5h (was: 1h 20m)
> Generate default configuration fragments based on annotations
> -------------------------------------------------------------
>
> Key: HDDS-1469
> URL: https://issues.apache.org/jira/browse/HDDS-1469
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> See the design doc in the parent jira for more details.
> In this jira I introduce a new annotation processor which can generate
> ozone-default.xml fragments based on the annotations which are introduced by
> HDDS-1468.
> The ozone-default-generated.xml fragments can be used directly by the
> OzoneConfiguration as I added a small code to the constructor to check ALL
> the available ozone-default-generated.xml files and add them to the available
> resources.
> With this approach we don't need to edit ozone-default.xml as all the
> configuration can be defined in java code.
> As a side effect each service will see only the available configuration keys
> and values based on the classpath. (If the ozone-default-generated.xml file
> of OzoneManager is not on the classpath of the SCM, SCM doesn't see the
> available configs.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
