[
https://issues.apache.org/jira/browse/HDDS-1430?focusedWorklogId=233645&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233645
]
ASF GitHub Bot logged work on HDDS-1430:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/19 16:55
Start Date: 26/Apr/19 16:55
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #752: HDDS-1430.
NPE if secure ozone if KMS uri is not defined. Contributed by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/752#discussion_r279027806
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/OzoneKMSUtil.java
##########
@@ -128,6 +128,9 @@ public static URI getKeyProviderUri(UserGroupInformation
ugi,
public static KeyProvider getKeyProvider(final Configuration conf,
final URI serverProviderUri) throws IOException{
+ if (serverProviderUri == null) {
Review comment:
We should not call getKeyProvider when provider uri is not defined. In
RpcClient#getKeyProvider() and RestClient#getkeyProvider(), we should do
String kpUri = getKeyProviderUri();
return kpUri == null ? null : OzoneKMSUtil.getKeyProvider(conf, kpUri);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 233645)
Time Spent: 40m (was: 0.5h)
> NPE if secure ozone if KMS uri is not defined.
> ----------------------------------------------
>
> Key: HDDS-1430
> URL: https://issues.apache.org/jira/browse/HDDS-1430
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Affects Versions: 0.4.0
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> OzoneKMSUtil.getKeyProvider throws NPE if KMS uri is not defined.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
