[
https://issues.apache.org/jira/browse/HDDS-1499?focusedWorklogId=239518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239518
]
ASF GitHub Bot logged work on HDDS-1499:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 23:54
Start Date: 08/May/19 23:54
Worklog Time Spent: 10m
Work Description: hanishakoneru commented on pull request #798:
HDDS-1499. OzoneManager Cache.
URL: https://github.com/apache/hadoop/pull/798#discussion_r282215862
##########
File path:
hadoop-hdds/common/src/test/java/org/apache/hadoop/utils/db/TestTypedRDBTableStore.java
##########
@@ -236,4 +249,66 @@ public void forEachAndIterator() throws Exception {
}
}
}
+
+ @Test
+ public void testTypedTableWithCache() throws Exception {
+ int iterCount = 10;
+ try (Table<String, String> testTable = createTypedTableWithCache(
+ "Seven", TableCache.CACHETYPE.FULLCACHE)) {
+
+ for (int x = 0; x < iterCount; x++) {
+ String key = Integer.toString(x);
+ String value = Integer.toString(x);
+ testTable.addCacheEntry(new CacheKey<>(key), new CacheValue<>(value,
+ CacheValue.OperationType.CREATED, x));
+ }
+
+ // As we have added to cache, so get should return value even if it
+ // does not exist in DB.
+ for (int x = 0; x < iterCount; x++) {
+ Assert.assertEquals(Integer.toString(1),
+ testTable.get(Integer.toString(1)));
+ }
+
+ }
+ }
+
+ @Test
+ public void testTypedTableWithCacheWithFewDeletedOperationType()
+ throws Exception {
+ int iterCount = 10;
+ try (Table<String, String> testTable = createTypedTableWithCache(
+ "Seven", TableCache.CACHETYPE.PARTIALCACHE)) {
+
+ for (int x = 0; x < iterCount; x++) {
+ String key = Integer.toString(x);
+ String value = Integer.toString(x);
+ if (x % 2 == 0) {
+ testTable.addCacheEntry(new CacheKey<>(key),
+ new CacheValue<>(value,
+ CacheValue.OperationType.CREATED, x));
+ } else {
+ testTable.addCacheEntry(new CacheKey<>(key), new CacheValue<>(value,
+ CacheValue.OperationType.DELETED, x));
+ }
+ }
+
+ // As we have added to cache, so get should return value even if it
+ // does not exist in DB.
+ for (int x = 0; x < iterCount; x++) {
+ if (x % 2 == 0) {
+ Assert.assertEquals(Integer.toString(x),
+ testTable.get(Integer.toString(x)));
+ } else {
+ Assert.assertNull(testTable.get(Integer.toString(x)));
+ }
+ }
+
+ testTable.cleanupCache(5);
+
+ GenericTestUtils.waitFor(() ->
+ ((TypedTable<String, String>) testTable).getCache().size() == 4,
+ 100, 5000);
+ }
Review comment:
Can we also check that the cache entries remaining in the cache are the
expected entries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239518)
Time Spent: 1h 50m (was: 1h 40m)
> OzoneManager Cache
> ------------------
>
> Key: HDDS-1499
> URL: https://issues.apache.org/jira/browse/HDDS-1499
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In this Jira, we shall implement a cache for Table.
> As with OM HA, we are planning to implement double buffer implementation to
> flush transaction in a batch, instead of using rocksdb put() for every
> operation. When this comes in to place we need cache in OzoneManager HA to
> handle/server the requests for validation/returning responses.
>
> This Jira will implement Cache as an integral part of the table. In this way
> users using this table does not need to handle like check cache/db. For this,
> we can update get API in the table to handle the cache.
>
> This Jira will implement:
> # Cache as a part of each Table.
> # Uses this cache in get().
> # Exposes api for cleanup, add entries to cache.
> Usage to add the entries in to cache will be done in further jira's.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
