[
https://issues.apache.org/jira/browse/HDDS-1491?focusedWorklogId=241041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241041
]
ASF GitHub Bot logged work on HDDS-1491:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 12:17
Start Date: 13/May/19 12:17
Worklog Time Spent: 10m
Work Description: bshashikant commented on issue #795: HDDS-1491. Ozone
KeyInputStream seek() should not read the chunk file.
URL: https://github.com/apache/hadoop/pull/795#issuecomment-491798375
Thanks @hanishakoneru for updating the patch. The patch looks good to me. I
am +1 on this.
Please address the checkStyle issues while committing.
We can also add tests with read failures in TestKeyInputStream, but these
can be added as a part of separate jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 241041)
Time Spent: 2h 10m (was: 2h)
> Ozone KeyInputStream seek() should not read the chunk file
> ----------------------------------------------------------
>
> Key: HDDS-1491
> URL: https://issues.apache.org/jira/browse/HDDS-1491
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> KeyInputStream#seek() calls BlockInputStream#seek() to adjust the buffer
> position to the seeked position. As part of the seek operation, the whole
> chunk is read from the container and stored in the buffer so that the buffer
> position can be advanced to the seeked position.
> We should not read from disk on a seek() operation. Instead, for a read
> operation, when the chunk file is read and put in the buffer, at that time,
> we can advance the buffer position to the previously seeked position.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
