[
https://issues.apache.org/jira/browse/HDDS-1461?focusedWorklogId=242940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242940
]
ASF GitHub Bot logged work on HDDS-1461:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/19 23:03
Start Date: 15/May/19 23:03
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #782: HDDS-1461.
Optimize listStatus api in OzoneFileSystem
URL: https://github.com/apache/hadoop/pull/782#discussion_r284484826
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1355,15 +1360,15 @@ public OzoneFileStatus getFileStatus(OmKeyArgs args)
throws IOException {
String bucketName = args.getBucketName();
String keyName = args.getKeyName();
- metadataManager.getLock().acquireBucketLock(volumeName, bucketName);
try {
+ metadataManager.getLock().acquireBucketLock(volumeName, bucketName);
Review comment:
why do we move the acquireBucketLock inside the try block? The original
pattern seems good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 242940)
Time Spent: 50m (was: 40m)
> Optimize listStatus api in OzoneFileSystem
> ------------------------------------------
>
> Key: HDDS-1461
> URL: https://issues.apache.org/jira/browse/HDDS-1461
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Filesystem, Ozone Manager
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently in listStatus we make multiple getFileStatus calls. This can be
> optimized by converting to a single rpc call for listStatus.
> Also currently listStatus has to traverse a directory recursively in order to
> list its immediate children. This happens because in OzoneManager all the
> metadata is stored in rocksdb sorted on keynames. The Jira also aims to fix
> this by using seek api provided by rocksdb.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
