[
https://issues.apache.org/jira/browse/HDDS-1406?focusedWorklogId=243215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243215
]
ASF GitHub Bot logged work on HDDS-1406:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/19 09:27
Start Date: 16/May/19 09:27
Worklog Time Spent: 10m
Work Description: lokeshj1703 commented on pull request #714: HDDS-1406.
Avoid usage of commonPool in RatisPipelineUtils.
URL: https://github.com/apache/hadoop/pull/714#discussion_r284612918
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java
##########
@@ -133,7 +173,86 @@ public Pipeline create(ReplicationFactor factor,
.build();
}
+
+ @Override
+ public void shutdown() {
+ forkJoinPool.shutdownNow();
Review comment:
We should also wait for the tasks to finish. We need to use awaitTermination
call. We can use timeout of 60 seconds? That is what is used in Scheduler class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 243215)
Time Spent: 7h 40m (was: 7.5h)
> Avoid usage of commonPool in RatisPipelineUtils
> -----------------------------------------------
>
> Key: HDDS-1406
> URL: https://issues.apache.org/jira/browse/HDDS-1406
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> We use parallelStream in during createPipline, this internally uses
> commonPool. Use Our own ForkJoinPool with parallelisim set with number of
> processors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
