[ https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125337#comment-13125337 ]
Todd Lipcon commented on HDFS-2301: ----------------------------------- Just two nits below. Feel free to just fix these on commit - no need for another review. +1. ---- Some funky indentation here: + throw new IOException("Service failed to start", e); + } ---- Better to pass "ie" as the second parameter: + LOG.info("Caught interrupted exception " + ie); > Start/stop appropriate namenode internal services during transition to active > and standby > ----------------------------------------------------------------------------------------- > > Key: HDFS-2301 > URL: https://issues.apache.org/jira/browse/HDFS-2301 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node > Affects Versions: HA branch (HDFS-1623) > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Fix For: HA branch (HDFS-1623) > > Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, > HDFS-2301.txt, HDFS-2301.txt > > > These changes are related to HDFS-1974 which introduced active and standby > states. This jira will address starting and stopping appropriate NN services > when entering and existing active and standby states. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira