[
https://issues.apache.org/jira/browse/HDDS-1559?focusedWorklogId=249352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249352
]
ASF GitHub Bot logged work on HDDS-1559:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/19 13:48
Start Date: 28/May/19 13:48
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #841: HDDS-1559.
Include committedBytes to determine Out of Space in VolumeChoosingPolicy.
Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/841#issuecomment-496524255
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 37 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 531 | trunk passed |
| +1 | compile | 269 | trunk passed |
| +1 | checkstyle | 75 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 915 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 151 | trunk passed |
| 0 | spotbugs | 328 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 546 | trunk passed |
| -0 | patch | 377 | Used diff version of patch file. Binary files and
potentially other changes not applied. Please rebase and squash commits if
necessary. |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 503 | the patch passed |
| +1 | compile | 287 | the patch passed |
| +1 | javac | 287 | the patch passed |
| +1 | checkstyle | 80 | the patch passed |
| +1 | mvnsite | 1 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 702 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 150 | the patch passed |
| +1 | findbugs | 560 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 183 | hadoop-hdds in the patch failed. |
| -1 | unit | 1271 | hadoop-ozone in the patch failed. |
| -1 | asflicense | 48 | The patch generated 17 ASF License warnings. |
| | | 6514 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.web.client.TestKeys |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.client.rpc.TestBCSID |
| | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
| | hadoop.ozone.container.common.impl.TestContainerPersistence |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-841/7/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/841 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux e16e0182751c 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed
Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 4a692bc |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-841/7/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-841/7/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-841/7/testReport/ |
| asflicense |
https://builds.apache.org/job/hadoop-multibranch/job/PR-841/7/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 5316 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/container-service U:
hadoop-hdds/container-service |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-841/7/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 249352)
Time Spent: 1h 40m (was: 1.5h)
> Include committedBytes to determine Out of Space in VolumeChoosingPolicy
> ------------------------------------------------------------------------
>
> Key: HDDS-1559
> URL: https://issues.apache.org/jira/browse/HDDS-1559
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Supratim Deka
> Assignee: Supratim Deka
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This is a follow-up from HDDS-1511 and HDDS-1535
> Currently when creating a new Container, the DN invokes
> RoundRobinVolumeChoosingPolicy:chooseVolume(). This routine checks for
> (volume available space > container max size). If no eligible volume is
> found, the policy throws a DiskOutOfSpaceException. This is the current
> behaviour.
> However, the computation of available space does not take into consideration
> the space
> that is going to be consumed by writes to existing containers which are still
> Open and accepting chunk writes.
> This Jira proposes to enhance the space availability check in chooseVolume by
> inclusion of committed space(committedBytes in HddsVolume) in the equation.
> The handling/management of the exception in Ratis will not be modified in
> this Jira. That will be scoped separately as part of Datanode IO Failure
> handling work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
