[ https://issues.apache.org/jira/browse/HDDS-1539?focusedWorklogId=250458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250458 ]
ASF GitHub Bot logged work on HDDS-1539: ---------------------------------------- Author: ASF GitHub Bot Created on: 29/May/19 20:31 Start Date: 29/May/19 20:31 Worklog Time Spent: 10m Work Description: ajayydv commented on pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288754975 ########## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/protocolPB/OMPBHelper.java ########## @@ -84,15 +84,14 @@ public static OzoneAclInfo convertOzoneAcl(OzoneAcl acl) { default: throw new IllegalArgumentException("ACL type is not recognized"); } - List<OzoneAclRights> aclRights = new ArrayList<>(); - - for (ACLType right : acl.getRights()) { - aclRights.add(OzoneAclRights.valueOf(right.name())); - } + List<OzoneAclRights> ozAclRights = + new ArrayList<>(acl.getAclBitSet().cardinality()); + acl.getAclBitSet().stream().forEach(a -> ozAclRights.add( + OzoneAclRights.valueOf(ACLType.values()[a].name()))); Review comment: @anuengineer thanks for review. I remember that discussion, i think reason was too many type castings involved in in streams. I dont see any consistent approach to tackle it. (We are using streams all over the place) Updated other stream usage to foreach loop. In this particular case foreach doesn't support Bitset so left it as it is. Hopefully performance of streams and parallel streams will improve in java. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 250458) Time Spent: 3h 50m (was: 3h 40m) > Implement addAcl,removeAcl,setAcl,getAcl for Volume > --------------------------------------------------- > > Key: HDDS-1539 > URL: https://issues.apache.org/jira/browse/HDDS-1539 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Labels: pull-request-available > Time Spent: 3h 50m > Remaining Estimate: 0h > > Implement addAcl,removeAcl,setAcl,getAcl for Volume -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org