[ https://issues.apache.org/jira/browse/HDDS-1539?focusedWorklogId=250507&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250507 ]
ASF GitHub Bot logged work on HDDS-1539: ---------------------------------------- Author: ASF GitHub Bot Created on: 29/May/19 20:49 Start Date: 29/May/19 20:49 Worklog Time Spent: 10m Work Description: anuengineer commented on pull request #847: HDDS-1539. Implement addAcl,removeAcl,setAcl,getAcl for Volume. Contributed Ajay Kumar. URL: https://github.com/apache/hadoop/pull/847#discussion_r288762165 ########## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.java ########## @@ -75,9 +77,20 @@ public OzoneAcl(ACLIdentityType type, String name, ACLType acl) { * @param name - Name of user * @param acls - Rights */ - public OzoneAcl(ACLIdentityType type, String name, List<ACLType> acls) { + public OzoneAcl(ACLIdentityType type, String name, BitSet acls) { + Objects.requireNonNull(type); + Objects.requireNonNull(acls); Review comment: No, I don't think so. If it is world, it has to be world. For Anonymous, you can insist that the client set the right value. So S3gateway will have to do the right thing to talk to us. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 250507) Time Spent: 5h 50m (was: 5h 40m) > Implement addAcl,removeAcl,setAcl,getAcl for Volume > --------------------------------------------------- > > Key: HDDS-1539 > URL: https://issues.apache.org/jira/browse/HDDS-1539 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Labels: pull-request-available > Time Spent: 5h 50m > Remaining Estimate: 0h > > Implement addAcl,removeAcl,setAcl,getAcl for Volume -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org