[ https://issues.apache.org/jira/browse/HDFS-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854937#comment-16854937 ]
Erik Krogen commented on HDFS-12979: ------------------------------------ Hey [~vagarychen], the new test case LGTM, although you need to shut down the {{MiniDFSCluster}} (and {{secondary}} ?) in your {{finally}} block. It looks like you also left a {{System.err.println()}} lying around. I'm still not a big fan of a static variable, but if there is no other good approach then okay. Ping [~shv] to see if he has any better ideas; I know Konstantin has had feelings about similar things in the past. Assuming we leave it in place, should we be resetting the static value in the {{shutdown}} of the mini-cluster, similar to how you reset it in the finally block of the test? > StandbyNode should upload FsImage to ObserverNode after checkpointing. > ---------------------------------------------------------------------- > > Key: HDFS-12979 > URL: https://issues.apache.org/jira/browse/HDFS-12979 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs > Reporter: Konstantin Shvachko > Assignee: Chen Liang > Priority: Major > Attachments: HDFS-12979.001.patch, HDFS-12979.002.patch, > HDFS-12979.003.patch, HDFS-12979.004.patch, HDFS-12979.005.patch, > HDFS-12979.006.patch, HDFS-12979.007.patch, HDFS-12979.008.patch, > HDFS-12979.009.patch, HDFS-12979.010.patch > > > ObserverNode does not create checkpoints. So it's fsimage file can get very > old making bootstrap of ObserverNode too long. A StandbyNode should copy > latest fsimage to ObserverNode(s) along with ANN. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org