[ https://issues.apache.org/jira/browse/HDFS-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16855353#comment-16855353 ]
Feilong He commented on HDFS-14356: ----------------------------------- Thanks [~Sammi] so much for your comments. Upon official doc, #pmem_map_file can return pmem address for existed file on pmem. I will verify this and consider the proposal in my above nearest comment. {quote}1. isNativePmemCacheLoader -> isNativeLoader, more generic {quote} I will change this method's name. {quote}2. can we just use "LOG.info("Initializing cache loader:" + this.getClass().getName()); in PmemMappableBlockLoader, so that log statement in NativePmemMappableBlockLoader can be removed? {quote} Good. I didn't fully get your point before. Thanks for detailed clarification. I will update the patch accordingly. > Implement HDFS cache on SCM with native PMDK libs > ------------------------------------------------- > > Key: HDFS-14356 > URL: https://issues.apache.org/jira/browse/HDFS-14356 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: caching, datanode > Reporter: Feilong He > Assignee: Feilong He > Priority: Major > Attachments: HDFS-14356.000.patch, HDFS-14356.001.patch, > HDFS-14356.002.patch, HDFS-14356.003.patch, HDFS-14356.004.patch, > HDFS-14356.005.patch, HDFS-14356.006.patch, HDFS-14356.007.patch > > > In this implementation, native PMDK libs are used to map HDFS blocks to SCM. > To use this implementation, user should build hadoop with PMDK libs by > specifying a build option. This implementation is only supported on linux > platform. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org