[
https://issues.apache.org/jira/browse/HDDS-1628?focusedWorklogId=253727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253727
]
ASF GitHub Bot logged work on HDDS-1628:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/19 13:11
Start Date: 04/Jun/19 13:11
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #902: HDDS-1628.
Fix the execution and return code of smoketest executor shell script
URL: https://github.com/apache/hadoop/pull/902#discussion_r290287400
##########
File path: hadoop-ozone/dev-support/checks/acceptance.sh
##########
@@ -13,6 +13,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
+DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
export HADOOP_VERSION=3
-hadoop-ozone/dist/target/ozone-*-SNAPSHOT/smoketest/test.sh
+$DIR/../../../hadoop-ozone/dist/target/ozone-*-SNAPSHOT/compose/test-all.sh
Review comment:
shellcheck:1: note: Double quote to prevent globbing and word splitting.
[SC2086]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 253727)
Time Spent: 20m (was: 10m)
> Fix the execution and return code of smoketest executor shell script
> --------------------------------------------------------------------
>
> Key: HDDS-1628
> URL: https://issues.apache.org/jira/browse/HDDS-1628
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Problem: Some of the smoketest executions were reported to green even if they
> contained failed tests.
> Root cause: the legacy test executor
> (hadoop-ozone/dist/src/main/smoketest/test.sh) which just calls the new
> executor script (hadoop-ozone/dist/src/main/compose/test-all.sh) didn't
> handle the return code well (the failure of the smoketests should be
> signalled by the bash return code)
> This patch:
> * Fixes the error code handling in smoketest/test.sh
> * Fixes the test execution in compose/test-all.sh (should work from any
> other directories)
> * Updates hadoop-ozone/dev-support/checks/acceptance.sh to use the newer
> test-all.sh executor instead of the old one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
