[ https://issues.apache.org/jira/browse/HDFS-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856847#comment-16856847 ]
Íñigo Goiri commented on HDFS-14545: ------------------------------------ Thanks [~ayushtkn] for [^HDFS-14545-HDFS-13891-02.patch], this looks good. * I started this crazy trend for newClientConnection() and newNamenodeConnection() which now follows with the other 2 new methods which do pretty much the same. Let's refactor these methods and make it a single one that takes the proto and hopefully can infer the translators (otherwise we could have an EnumMap or similar). * What about creating something equivalent to NamenodeProtocols which is RouterProtocols? * Let's use {{nss.isEmpty()}} instead of {{size() == 0}}. * Should we check the operation at the very beginning instead of first checking if we have nameservices? * I was thinking on having a configuration to let the Router reply or do the routing itself. It might be overkilled. * Do we want to get rid of the old tests? I need to check carefully as it might be already covered. * We may want to extend the coverage. > RBF: Router should support GetUserMappingsProtocol > -------------------------------------------------- > > Key: HDFS-14545 > URL: https://issues.apache.org/jira/browse/HDFS-14545 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Íñigo Goiri > Assignee: Ayush Saxena > Priority: Major > Attachments: HDFS-14545-HDFS-13891-01.patch, > HDFS-14545-HDFS-13891-02.patch, HDFS-14545-HDFS-13891.000.patch > > > We should be able to check the groups for a user from a Router. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org