[
https://issues.apache.org/jira/browse/HDDS-1605?focusedWorklogId=254778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254778
]
ASF GitHub Bot logged work on HDDS-1605:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 23:49
Start Date: 05/Jun/19 23:49
Worklog Time Spent: 10m
Work Description: hanishakoneru commented on pull request #867:
HDDS-1605. Implement AuditLogging for OM HA Bucket write requests.
URL: https://github.com/apache/hadoop/pull/867#discussion_r290977673
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
##########
@@ -152,27 +160,35 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
OMException.ResultCodes.BUCKET_ALREADY_EXISTS);
}
- LOG.debug("created bucket: {} in volume: {}", bucketName, volumeName);
- omMetrics.incNumBuckets();
-
// Update table cache.
metadataManager.getBucketTable().addCacheEntry(new CacheKey<>(bucketKey),
new CacheValue<>(Optional.of(omBucketInfo), transactionLogIndex));
- // return response.
+
+ } catch (IOException ex) {
+ exception = ex;
+ } finally {
+ metadataManager.getLock().releaseBucketLock(volumeName, bucketName);
+ metadataManager.getLock().releaseVolumeLock(volumeName);
+
+ // Performing audit logging outside of the lock.
+ auditLog(auditLogger, buildAuditMessage(OMAction.CREATE_BUCKET,
+ omBucketInfo.toAuditMap(), exception, userInfo));
+ }
Review comment:
Yes I meant why not outside the finally block as generally we keep the must
be done things (like lock releases) in the finally block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 254778)
Time Spent: 1h 40m (was: 1.5h)
> Implement AuditLogging for OM HA Bucket write requests
> ------------------------------------------------------
>
> Key: HDDS-1605
> URL: https://issues.apache.org/jira/browse/HDDS-1605
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In this Jira, we shall implement audit logging for OM HA Bucket write
> requests.
> As now we cannot use userName, IpAddress from Server API's as these will be
> null, because the requests are executed under GRPC context. So, in our
> AuditLogger API's we need to pass username and remoteAddress which we can get
> from OMRequest after HDDS-1600 and use these during audit logging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
