[ https://issues.apache.org/jira/browse/HDFS-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860176#comment-16860176 ]
Íñigo Goiri commented on HDFS-12914: ------------------------------------ [^HDFS-12914.007.patch] has a couple failed check style issues. Given we have to fix those, I'll go again with my minor comments :) * For UnregisteredNodeException, I was thinking on just a debug message. * For the {{checkBlockReportLease()}}, we can save two calls by returning right away. I would definitely go for that: {code} public boolean checkBlockReportLease(BlockReportContext context, final DatanodeID nodeID) throws UnregisteredNodeException { if (context == null) { return true; } DatanodeDescriptor node = datanodeManager.getDatanode(nodeID); final long startTime = Time.monotonicNow(); return blockReportLeaseManager.checkLease( node, startTime, context.getLeaseId()); } {code} > Block report leases cause missing blocks until next report > ---------------------------------------------------------- > > Key: HDFS-12914 > URL: https://issues.apache.org/jira/browse/HDFS-12914 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.8.0, 2.9.2 > Reporter: Daryn Sharp > Assignee: Santosh Marella > Priority: Critical > Attachments: HDFS-12914-branch-2.001.patch, > HDFS-12914-trunk.00.patch, HDFS-12914-trunk.01.patch, HDFS-12914.005.patch, > HDFS-12914.006.patch, HDFS-12914.007.patch > > > {{BlockReportLeaseManager#checkLease}} will reject FBRs from DNs for > conditions such as "unknown datanode", "not in pending set", "lease has > expired", wrong lease id, etc. Lease rejection does not throw an exception. > It returns false which bubbles up to {{NameNodeRpcServer#blockReport}} and > interpreted as {{noStaleStorages}}. > A re-registering node whose FBR is rejected from an invalid lease becomes > active with _no blocks_. A replication storm ensues possibly causing DNs to > temporarily go dead (HDFS-12645), leading to more FBR lease rejections on > re-registration. The cluster will have many "missing blocks" until the DNs > next FBR is sent and/or forced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org