[
https://issues.apache.org/jira/browse/HDFS-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862868#comment-16862868
]
Steve Loughran commented on HDFS-9913:
--------------------------------------
Could you stick the patch up as a github PR, referencing this JIRA in the title
-we're moving to that for reviewing and it does work well.
At a quick glance, other some few minor details related to format I don't see
much in production code that needs changing; I'm going to make more suggestions
for the tests, primarily to meet my key goal "an error message on a jenkins
build is sufficient to immediate determine what assertion failed, and hence
line you up for fixing"
you are also going to need to add a test to AbstractContractDistCpTest too,
because that's used by all the object store connectors to validate their
support for distcp: even though on some stores the trash option is O(data) and
so slow, That'll be a fact to add to the docs
> DispCp doesn't use Trash with -delete option
> --------------------------------------------
>
> Key: HDFS-9913
> URL: https://issues.apache.org/jira/browse/HDFS-9913
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: distcp
> Affects Versions: 2.6.0
> Reporter: Konstantin Shaposhnikov
> Assignee: Shen Yinjie
> Priority: Major
> Attachments: HDFS-9913_1.patch
>
>
> Documentation for DistCp -delete option says
> ([http://hadoop.apache.org/docs/current/hadoop-distcp/DistCp.html]):
> | The deletion is done by FS Shell. So the trash will be used, if it is
> enable.
> However it seems to be no longer the case. The latest source code
> (https://svn.apache.org/repos/asf/hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java)
> uses `FileSystem.delete` and trash options seems to be not applied.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
