[ https://issues.apache.org/jira/browse/HDFS-14340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866256#comment-16866256 ]
Hudson commented on HDFS-14340: ------------------------------- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16770 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/16770/]) HDFS-14340. Lower the log level when can't get postOpAttr. Contributed (weichiu: rev 098c325a78dce2697ec94a22a4a3981fa5a3849e) * (edit) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java > Lower the log level when can't get postOpAttr > --------------------------------------------- > > Key: HDFS-14340 > URL: https://issues.apache.org/jira/browse/HDFS-14340 > Project: Hadoop HDFS > Issue Type: Improvement > Components: nfs > Reporter: Anuhan Torgonshar > Assignee: Anuhan Torgonshar > Priority: Major > Labels: easyfix > Fix For: 3.3.0, 3.2.1, 3.1.3 > > Attachments: HDFS-14340.trunk.patch > > > I think should lower the log level when can't get postOpAttr in > _*hadoop-2.8.5-src/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/**RpcProgramNfs3.java*_. > > > {code:java} > **************The fisrt code snippet*************** > //the problematic log level ERROR, at line 1044 > try { > dirWcc = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(preOpDirAttr), > dfsClient, dirFileIdPath, iug); > } catch (IOException e1) { > LOG.error("Can't get postOpDirAttr for dirFileId: " > + dirHandle.getFileId(), e1); > } > **************The second code snippet*************** > //other practice in similar code snippets, line number is 475, the log > assigned with INFO level > try { > wccData = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(preOpAttr), > dfsClient, fileIdPath, iug); > } catch (IOException e1) { > LOG.info("Can't get postOpAttr for fileIdPath: " + fileIdPath, e1); > } > **************The third code snippet*************** > //other practice in similar code snippets, line number is 1405, the log > assigned with INFO level > try { > fromDirWcc = Nfs3Utils.createWccData( > Nfs3Utils.getWccAttr(fromPreOpAttr), dfsClient, fromDirFileIdPath,iug); > toDirWcc = Nfs3Utils.createWccData(Nfs3Utils.getWccAttr(toPreOpAttr), > dfsClient, toDirFileIdPath, iug); > } catch (IOException e1) { > LOG.info("Can't get postOpDirAttr for " + fromDirFileIdPath + " or" > + toDirFileIdPath, e1); > } > {code} > Therefore, I think the logging practices should be consistent in similar > contexts. When the code catches _*IOException*_ for *_getWccAttr()_* method, > it more likely prints a log message with _*INFO*_ level, a lower level. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org