[ 
https://issues.apache.org/jira/browse/HDFS-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131114#comment-13131114
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2459:
----------------------------------------------

- add private to the fields in XxxWritable
- add javadoc for JournalWireProtocol.versionID (see ClientDatanodeWireProtocol)
- In JournalProtocolTranslatorR23,
-* remove getProxyWithoutRetry()
-* add @Override to close()
- there are two NamenodeRegistration classes, forgot to remove the old one?
- the new import in NameNodeRpcServer is unused

                
> Separate datatypes for Journal protocol
> ---------------------------------------
>
>                 Key: HDFS-2459
>                 URL: https://issues.apache.org/jira/browse/HDFS-2459
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.24.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-2459.txt, HDFS-2459.txt
>
>
> This jira separates for JournalProtocol the wire types from the types used by 
> the client and server, similar to HDFS-2181.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to