[
https://issues.apache.org/jira/browse/HDDS-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866871#comment-16866871
]
Eric Yang commented on HDDS-1667:
---------------------------------
[~elek], {quote}And IMHO it's not a good way to go forward. (I may be wrong,
but it's a big change and should be discussed first in a separated
thread){quote}
I am currently blinded by what is production compose file vs test compose file.
There is no clear indicator to distinguish between the two. If you can list
what should use apache/ozone, and apache/ozone-runner, it would help.
{quote}ozonesecure can't be started any more from the compose/ozonesecure
folder due to the usage of HADOOP_IMAGE. I don't see any reason to use
HADOOP_IMAGE{quote}
This was following the existing code that uses HADOOP_IMAGE. It is not a
concept that is invented here, but an attempt to line up Hadoop image using the
same syntax. I have trouble to follow HADOOP_IMAGE usage in the current
source. Hence, I [highlight
this|https://issues.apache.org/jira/browse/HDDS-1667?focusedCommentId=16863430&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16863430]
is a problem and request your assistance for clarification on the usage of
HADOOP_IMAGE. From my point of view, it did not work, but we still need to
make hadoop image usage consist to ensure that we have ability to update the
hadoop image reference globally.
{quote}I think you didn't execute all the smoketests before posting the patch.
Would you be so kind to post this patch as a github pull request to get full
acceptance test results?{quote}
I am blocked by HDDS-1609 which prevent acceptance test to function on my
system. It would be easier if acceptance test is part of the "maven verify" to
ensure this is exercise as part of the build process instead of having to go
into a less known directory to perform smoke test. We may seen less trunk
regression than we do today. This is separate issue, and I open HDDS-1704 to
track the necessary improvement for developers.
> Docker compose file may referring to incorrect docker image name
> ----------------------------------------------------------------
>
> Key: HDDS-1667
> URL: https://issues.apache.org/jira/browse/HDDS-1667
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Trivial
> Fix For: 0.4.1
>
> Attachments: HDDS-1667.001.patch, HDDS-1667.002.patch,
> HDDS-1667.003.patch, HDDS-1667.004.patch, HDDS-1667.005.patch
>
>
> In fault injection test, the docker compose file is templated using:
> ${user.name}/ozone:${project.version}
> If user pass in parameter -Ddocker.image to cause docker build to generate a
> different name. This can cause fault injection test to fail/stuck because it
> could not find the required docker image. The fix is simply use docker.image
> token to filter docker compose file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
