[
https://issues.apache.org/jira/browse/HDDS-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867858#comment-16867858
]
Eric Yang commented on HDDS-1554:
---------------------------------
[~elek] Thank you for the review. The disk tests development is stuck on
container and filesystem uid issue. Until we can have closure on HDDS-1609.
Some of the test can not be execrised.
{quote}The other problem with this code fragment that you assume that the safe
mode is true in case of any exception. In case of any exception you wait 60
seconds in the tests without checking what is exactly the problem.{quote}
The current Ozone client is throwing error without retry. I have filed
HDDS-1583 to make Ozone client more robust, then we can refine
testWaitForSafeMode in read-only test.
{quote}I think it's better to commit working tests one by one. Let's focus on
the corruption-test, for now. As you requested I created a PR to show how is it
possible to test it with the existing tools. (With a more simple way).{quote}
Thank you for sharing your implementation.
# I think it is risky to dump all tests in dist project. It is a snowball
growing. It would be nice to have ability to selectively run test cases from
maven cli.
# It becomes increasing difficult to identify which compose file is used by
test and which one is meant for release because all compose files are stored in
dist/src/main subdirectory.
# In read-only test, it requires sudo privileges to change files to read-only.
This is another security risk that allowing hadoop user to be sudo in
container, it gives the container ability to jail break out of container. This
is not ideal.
# Can not simulate disk full because test result output is written inside
container.
> Create disk tests for fault injection test
> ------------------------------------------
>
> Key: HDDS-1554
> URL: https://issues.apache.org/jira/browse/HDDS-1554
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Labels: pull-request-available
> Attachments: HDDS-1554.001.patch, HDDS-1554.002.patch,
> HDDS-1554.003.patch, HDDS-1554.004.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current plan for fault injection disk tests are:
> # Scenario 1 - Read/Write test
> ## Run docker-compose to bring up a cluster
> ## Initialize scm and om
> ## Upload data to Ozone cluster
> ## Verify data is correct
> ## Shutdown cluster
> # Scenario 2 - Read/Only test
> ## Repeat Scenario 1
> ## Mount data disk as read only
> ## Try to write data to Ozone cluster
> ## Validate error message is correct
> ## Shutdown cluster
> # Scenario 3 - Corruption test
> ## Repeat Scenario 2
> ## Shutdown cluster
> ## Modify data disk data
> ## Restart cluster
> ## Validate error message for read from corrupted data
> ## Validate error message for write to corrupted volume
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
