[ 
https://issues.apache.org/jira/browse/HDFS-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131964#comment-13131964
 ] 

Uma Maheswara Rao G commented on HDFS-2452:
-------------------------------------------

Here is a patch with CountDownLatch.

Other changes in previous patch is:
 
1) fixed one null pointer, which is caused because of not mocking the getConf 
on DN.
 Added the mock in test. 
 
2) DataXceiverAspects file apache header was not a header comment
    {code}
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
{code}
updated it.

3) System.setProperty("fi.enabledOOM", null); also changed to 
System.setProperty("fi.enabledOOM", "false");
   because can not set null in props.
   Also changed the check in aspectj file to check with true.


To be frank, i am not familiar with aspectJ programs. 
So, requesting Cos to review once with my changes. One more thing is when i ran 
the tests with your command, i don't see any aspects injected in to 
DataXceiver.class and not running test. Not sure my compilations has the 
problems with aspectj. Since this is urgent for some of the load tests running 
by Konstantin, i updated the patch here.

Konstantin, can you check the patch and give the test run once.


Thanks,
Uma
                
> OutOfMemoryError in DataXceiverServer takes down the DataNode
> -------------------------------------------------------------
>
>                 Key: HDFS-2452
>                 URL: https://issues.apache.org/jira/browse/HDFS-2452
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Shvachko
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.22.0
>
>         Attachments: HDFS-2452-22Branch.2.patch, HDFS-2452-22branch.1.patch, 
> HDFS-2452-22branch.patch, HDFS-2452-22branch.patch, HDFS-2452-22branch.patch, 
> HDFS-2452-22branch.patch
>
>
> OutOfMemoryError brings down DataNode, when DataXceiverServer tries to spawn 
> a new data transfer thread.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to