[ https://issues.apache.org/jira/browse/HDFS-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871888#comment-16871888 ]
Sahil Takiar commented on HDFS-13984: ------------------------------------- Yeah, this makes sense to me. [~yangjiandan]do you have plans to continue working on this? A few comments: * Use {{javaObjectIsOfClass}} in {{jni_helper.h}} * The {{FileNotFoundException}} needs to be freed before returning null > getFileInfo of libhdfs call NameNode#getFileStatus twice > -------------------------------------------------------- > > Key: HDFS-13984 > URL: https://issues.apache.org/jira/browse/HDFS-13984 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs > Reporter: Jiandan Yang > Assignee: Jiandan Yang > Priority: Major > Attachments: HDFS-13984.001.patch, HDFS-13984.002.patch, > HDFS-13984.003.patch > > > getFileInfo in hdfs.c calls *FileSystem#exists* first, then calls > *FileSystem#getFileStatus*. > *FileSystem#exists* also call *FileSystem#getFileStatus*, just as follows: > {code:java} > public boolean exists(Path f) throws IOException { > try { > return getFileStatus(f) != null; > } catch (FileNotFoundException e) { > return false; > } > } > {code} > and finally this leads to call NameNodeRpcServer#getFileInfo twice. > Actually we can implement by calling once. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org