[ https://issues.apache.org/jira/browse/HDFS-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871927#comment-16871927 ]
Anu Engineer commented on HDFS-14598: ------------------------------------- [~jojochuang] Please let me know if you would like this to be backported. I do see the other patch went into other branches. {quote}Pushed to trunk, branch-3.2 and branch-3.1 Thanks [~liumihust] for the contribution and [~anu] for review! {quote} > Findbugs warning caused by HDFS-12487 > ------------------------------------- > > Key: HDFS-14598 > URL: https://issues.apache.org/jira/browse/HDFS-14598 > Project: Hadoop HDFS > Issue Type: Bug > Components: diskbalancer > Reporter: Wei-Chiu Chuang > Assignee: He Xiaoqiao > Priority: Minor > Labels: newbie > Fix For: 3.3.0 > > Attachments: HDFS-14598.001.patch > > > https://builds.apache.org/job/PreCommit-HDFS-Build/27038/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html > {noformat} > Redundant nullcheck of block, which is known to be non-null in > org.apache.hadoop.hdfs.server.datanode.DiskBalancer$DiskBalancerMover.getBlockToCopy(FsVolumeSpi$BlockIterator, > DiskBalancerWorkItem) > Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details) > In class org.apache.hadoop.hdfs.server.datanode.DiskBalancer$DiskBalancerMover > In method > org.apache.hadoop.hdfs.server.datanode.DiskBalancer$DiskBalancerMover.getBlockToCopy(FsVolumeSpi$BlockIterator, > DiskBalancerWorkItem) > Value loaded from block > Return value of > org.apache.hadoop.hdfs.server.datanode.fsdataset.FsVolumeSpi$BlockIterator.nextBlock() > of type org.apache.hadoop.hdfs.protocol.ExtendedBlock > Redundant null check at DiskBalancer.java:[line 912] > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org