[
https://issues.apache.org/jira/browse/HDFS-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874289#comment-16874289
]
He Xiaoqiao commented on HDFS-14586:
------------------------------------
Thanks [~huyongfa] for your detailed comments again. IIUC, you try to correct
the current time using the method {{floor}} both at {{Emptier}} thread and
{{deleteCheckpoint}} to smooth time cost by {{deleteCheckpoint}}. Thus one
checkpoint path may be deleted which should be delete next time at some corner
case, right? Of course, I agree that it is not serious issue.
Sorry about that I do not express clearer above. I suggest that we could get
the current time once then used it anywhere when need to get the current time,
for instance {{createCheckpoint}} and {{deleteCheckpoint}} passed the time as
one parameter. Please correct me if something wrong. Thanks again.
> Trash missing delete the folder which near timeout checkpoint
> -------------------------------------------------------------
>
> Key: HDFS-14586
> URL: https://issues.apache.org/jira/browse/HDFS-14586
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: hu yongfa
> Assignee: hu yongfa
> Priority: Major
> Attachments: HDFS-14586.001.patch
>
>
> when trash timeout checkpoint coming, trash will delete the old folder first,
> then create a new checkpoint folder.
> as the delete action may spend a long time, such as 2 minutes, so the new
> checkpoint folder created late.
> at the next trash timeout checkpoint, trash will skip delete the new
> checkpoint folder, because the new checkpoint folder is
> less than a checkpoint interval.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
