[ 
https://issues.apache.org/jira/browse/HDFS-14599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874336#comment-16874336
 ] 

Íñigo Goiri commented on HDFS-14599:
------------------------------------

+1 on  [^HDFS-14599.002.patch].

> HDFS-12487 breaks test 
> TestDiskBalancer.testDiskBalancerWithFedClusterWithOneNameServiceEmpty
> ---------------------------------------------------------------------------------------------
>
>                 Key: HDFS-14599
>                 URL: https://issues.apache.org/jira/browse/HDFS-14599
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: diskbalancer
>    Affects Versions: 3.3.0, 3.2.1, 3.1.3
>            Reporter: Wei-Chiu Chuang
>            Assignee: He Xiaoqiao
>            Priority: Major
>              Labels: newbie
>         Attachments: HDFS-14599.001.patch, HDFS-14599.002.patch
>
>
> It looks like HDFS-12487 changes the error message expected by 
> {{TestDiskBalancer#testDiskBalancerWithFedClusterWithOneNameServiceEmpty}}.
> The test expects error "There are no blocks in the blockPool" but after 
> HDFS-12487, it returns error string "NextBlock call returned null.No valid 
> block to copy."
> Probably the simplest approach to fix it is to update the expected error 
> string.
> Thoughts? [~bharatviswa] you crafted the test in HDFS-13715. Should we update 
> the expected error string, or revert HDFS-12487?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to