[
https://issues.apache.org/jira/browse/HDFS-14611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875281#comment-16875281
]
Konstantin Shvachko commented on HDFS-14611:
--------------------------------------------
Looks reasonable overall, simpler than the previous approach, and preserves
compatibility, which is the key point. Minor comments:
# {{SaslDataTransferServer}} - some unused imports still need to be reverted
# {{public byte[] createPassword(BlockTokenIdentifier identifier)}} - may not
need to be public
# Update JavaDoc for the new parameter in constructor
{{BlockTokenSecretManager()}}
# Also check the checkstyle warnings.
> Move handshake secret field from Token to BlockAccessToken
> ----------------------------------------------------------
>
> Key: HDFS-14611
> URL: https://issues.apache.org/jira/browse/HDFS-14611
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Blocker
> Attachments: HDFS-14611.001.patch, HDFS-14611.002.patch
>
>
> Currently the handshake secret is included in Token, but conceptually this
> should belong to Block Access Token only. More importantly, having this field
> in Token could potentially break compatibility. Moreover, having this field
> as part of Block Access Token also means we may not need to encrypt this
> field anymore, because block access token is already encrypted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
