[
https://issues.apache.org/jira/browse/HDDS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876358#comment-16876358
]
Eric Yang commented on HDDS-1735:
---------------------------------
{quote}If I understood well, you don't agree to use an existing
committed/approved feature (pom.ozone.xml introduced by HDDS-1115), because you
have an idea/plan to replace it with something else, sometime in the
future.{quote}
Hadoop already provide it's own pre-commit build validation suites (yetus).
The optimization of building speed should not introduce a complete fork on how
CI is done for Hadoop sub-project. This is not a plan to replace it with
something else, rather ask nicely to follow existing methodology. This helps
us to catch things like javadoc issues, checkstyle white space rules that are
more aligned with Hadoop parent project conventions.
> Create separate unit and integration test executor dev-support script
> ---------------------------------------------------------------------
>
> Key: HDDS-1735
> URL: https://issues.apache.org/jira/browse/HDDS-1735
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains multiple helper script to
> execute different type of testing (findbugs, rat, unit, build).
> They easily define how tests should be executed, with the following contract:
> * The problems should be printed out to the console
> * in case of test failure a non zero exit code should be used
>
> The tests are working well (in fact I have some experiments with executing
> these scripts on k8s and argo where all the shell scripts are executed
> parallel) but we need some update:
> 1. Most important: the unit tests and integration tests can be separated.
> Integration tests are more flaky and it's better to have a way to run only
> the normal unit tests
> 2. As HDDS-1115 introduced a pom.ozone.xml it's better to use them instead
> of the magical "am pl hadoop-ozone-dist" trick--
> 3. To make it possible to run blockade test in containers we should use - T
> flag with docker-compose
> 4. checkstyle violations are printed out to the console
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
