[ https://issues.apache.org/jira/browse/HDDS-1731?focusedWorklogId=271179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271179 ]
ASF GitHub Bot logged work on HDDS-1731: ---------------------------------------- Author: ASF GitHub Bot Created on: 02/Jul/19 20:12 Start Date: 02/Jul/19 20:12 Worklog Time Spent: 10m Work Description: arp7 commented on pull request #1044: HDDS-1731. Implement File CreateFile Request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1044#discussion_r299664639 ########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java ########## @@ -162,73 +164,88 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, KeyArgs keyArgs = createKeyRequest.getKeyArgs(); - String volumeName = keyArgs.getVolumeName(); String bucketName = keyArgs.getBucketName(); String keyName = keyArgs.getKeyName(); OMMetrics omMetrics = ozoneManager.getMetrics(); omMetrics.incNumKeyAllocates(); - AuditLogger auditLogger = ozoneManager.getAuditLogger(); - - Map<String, String> auditMap = buildKeyArgsAuditMap(keyArgs); - - OMResponse.Builder omResponse = OMResponse.newBuilder().setCmdType( - OzoneManagerProtocolProtos.Type.CreateKey).setStatus( - OzoneManagerProtocolProtos.Status.OK).setSuccess(true); - + OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager(); + OmKeyInfo omKeyInfo = null; + final List< OmKeyLocationInfo > locations = new ArrayList<>(); + FileEncryptionInfo encryptionInfo = null; + IOException exception = null; + boolean acquireLock = false; Review comment: There seems to be a bug here. `acquireLock` is never set to true in any code path. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 271179) Time Spent: 2h 10m (was: 2h) > Implement File CreateFile Request to use Cache and DoubleBuffer > --------------------------------------------------------------- > > Key: HDDS-1731 > URL: https://issues.apache.org/jira/browse/HDDS-1731 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > In this Jira, we shall implement createFile request according to the HA > model, and use cache and double buffer. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org