[
https://issues.apache.org/jira/browse/HDFS-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877571#comment-16877571
]
He Xiaoqiao commented on HDFS-12914:
------------------------------------
Thanks [~cheersyang] for your report and [~starphin] for your double-check.
Sorry for late response. the root cause of this issue about building broken:
a. HDFS-12914 cherry-pick from branch-3.1 commit to branch-3.0.
b. HDFS-11673 changes visible scope of method #processReport from private to
default/protect and commit to branch-3.1 and later but not back-port to
branch-3.0 and earlier version.
c. I don't check build result after [~jojochuang] help to commit.
It is safe to change the visible scope BlockManager#processReport to
protect/default.
I just submit another patch for branch-3.0 and include changing
BlockManager#processReport visible. cc [~jojochuang] Please help to take
another review.
Some commit notes for branch-3.0 if anyone would like to take a review and help
to commit:
1. Please revert HDFS-12914 patch;
2. Re-apply [^HDFS-12914.branch-3.0.patch] to branch-3.0.
Thanks [~cheersyang],[~starphin],[~jojochuang] again.
> Block report leases cause missing blocks until next report
> ----------------------------------------------------------
>
> Key: HDFS-12914
> URL: https://issues.apache.org/jira/browse/HDFS-12914
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.8.0, 2.9.2
> Reporter: Daryn Sharp
> Assignee: Santosh Marella
> Priority: Critical
> Fix For: 3.0.4, 3.3.0, 3.2.1, 3.1.3
>
> Attachments: HDFS-12914-branch-2.001.patch,
> HDFS-12914-trunk.00.patch, HDFS-12914-trunk.01.patch, HDFS-12914.005.patch,
> HDFS-12914.006.patch, HDFS-12914.007.patch, HDFS-12914.008.patch,
> HDFS-12914.009.patch, HDFS-12914.branch-2.patch, HDFS-12914.branch-3.0.patch,
> HDFS-12914.branch-3.1.001.patch, HDFS-12914.branch-3.1.002.patch,
> HDFS-12914.branch-3.2.patch, HDFS-12914.utfix.patch
>
>
> {{BlockReportLeaseManager#checkLease}} will reject FBRs from DNs for
> conditions such as "unknown datanode", "not in pending set", "lease has
> expired", wrong lease id, etc. Lease rejection does not throw an exception.
> It returns false which bubbles up to {{NameNodeRpcServer#blockReport}} and
> interpreted as {{noStaleStorages}}.
> A re-registering node whose FBR is rejected from an invalid lease becomes
> active with _no blocks_. A replication storm ensues possibly causing DNs to
> temporarily go dead (HDFS-12645), leading to more FBR lease rejections on
> re-registration. The cluster will have many "missing blocks" until the DNs
> next FBR is sent and/or forced.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
