[
https://issues.apache.org/jira/browse/HDDS-1603?focusedWorklogId=273067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-273067
]
ASF GitHub Bot logged work on HDDS-1603:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/19 06:04
Start Date: 08/Jul/19 06:04
Worklog Time Spent: 10m
Work Description: mukul1987 commented on pull request #1019: HDDS-1603.
Handle Ratis Append Failure in Container State Machine. Contributed by Supratim
Deka
URL: https://github.com/apache/hadoop/pull/1019#discussion_r300932058
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
##########
@@ -180,4 +188,77 @@ public void testPipelineCloseWithPipelineAction() throws
Exception {
} catch (PipelineNotFoundException e) {
}
}
+
+ @Test
+ public void testPipelineCloseWithLogFailure() throws IOException {
+
+ EventQueue eventQ = (EventQueue) scm.getEventQueue();
+ PipelineActionHandler pipelineActionTest =
+ Mockito.mock(PipelineActionHandler.class);
+ eventQ.addHandler(SCMEvents.PIPELINE_ACTIONS, pipelineActionTest);
+ ArgumentCaptor<PipelineActionsFromDatanode> actionCaptor =
+ ArgumentCaptor.forClass(PipelineActionsFromDatanode.class);
+
+ ContainerInfo containerInfo = containerManager
+ .allocateContainer(RATIS, THREE, "testOwner");
+ ContainerWithPipeline containerWithPipeline =
+ new ContainerWithPipeline(containerInfo,
+ pipelineManager.getPipeline(containerInfo.getPipelineID()));
+ Pipeline openPipeline = containerWithPipeline.getPipeline();
+ RaftGroupId groupId = RaftGroupId.valueOf(openPipeline.getId().getId());
+
+ try {
+ pipelineManager.getPipeline(openPipeline.getId());
+ } catch (PipelineNotFoundException e) {
+ Assert.assertTrue("pipeline should exist", false);
Review comment:
In Junit, the test will exit if an uncaught exception is thrown, so this
might not be needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 273067)
Time Spent: 1h (was: 50m)
> Handle Ratis Append Failure in Container State Machine
> ------------------------------------------------------
>
> Key: HDDS-1603
> URL: https://issues.apache.org/jira/browse/HDDS-1603
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Datanode, SCM
> Reporter: Supratim Deka
> Assignee: Supratim Deka
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> RATIS-573 would add notification to the State Machine on encountering failure
> during Log append.
> The scope of this jira is to build on RATIS-573 and define the handling for
> log append failure in Container State Machine.
> 1. Enqueue pipeline unhealthy action to SCM, add a reason code to the message.
> 2. Trigger heartbeat to SCM
> 3. Notify Ratis volume unhealthy to the Datanode, so that DN can trigger
> async volume checker
> Changes in the SCM to leverage the additional failure reason code, is outside
> the scope of this jira.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
