[
https://issues.apache.org/jira/browse/HDDS-1802?focusedWorklogId=277101&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277101
]
ASF GitHub Bot logged work on HDDS-1802:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/19 01:11
Start Date: 16/Jul/19 01:11
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1100:
HDDS-1802. Add Eviction policy for table cache.
URL: https://github.com/apache/hadoop/pull/1100#discussion_r303694634
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/TableCacheImpl.java
##########
@@ -70,7 +77,10 @@ public void put(CACHEKEY cacheKey, CACHEVALUE value) {
@Override
public void cleanup(long epoch) {
- executorService.submit(() -> evictCache(epoch));
+ // If it is never do nothing.
Review comment:
It is caller responsibility to call this method after the flush. And right
now this is called only after flushing to DB from OzoneManagerDoubleBuffer.
So, if it is NEVER, we will not do the cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 277101)
Time Spent: 1h (was: 50m)
> Add Eviction policy for table cache
> -----------------------------------
>
> Key: HDDS-1802
> URL: https://issues.apache.org/jira/browse/HDDS-1802
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In this Jira we will add eviction policy for table cache.
> In this Jira, we will add 2 eviction policies for the cache.
> NEVER, // Cache will not be cleaned up. This mean's the table maintains full
> cache.
> AFTERFLUSH // Cache will be cleaned up, once after flushing to DB.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
