[ https://issues.apache.org/jira/browse/HDFS-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886154#comment-16886154 ]
Ayush Saxena commented on HDFS-13577: ------------------------------------- This seems fixed :: {code:java} if (!added) { System.err.println("Cannot add mount point " + mount); } return added; {code} The said message shall be printed when added is false, and same false is returned. Then :: {code:java} if (addMount(argv, i)) { System.out.println("Successfully added mount point " + argv[i]); } else { exitCode = -1; } {code} Here addMount(argv,i) receives response as False, Moves to else, sets exit code to -1. Verified, Seems not an issue now. Can resolve this now!!! > RBF: Failed mount point operations, returns wrong exit code. > ------------------------------------------------------------ > > Key: HDFS-13577 > URL: https://issues.apache.org/jira/browse/HDFS-13577 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Y. SREENIVASULU REDDY > Assignee: Dibyendu Karmakar > Priority: Major > Labels: RBF > > If client is performed add mount point with some special character, mount > point add is failed. > And prints the message like > {noformat} > 18/05/17 09:58:34 DEBUG ipc.ProtobufRpcEngine: Call: addMountTableEntry took > 19ms Cannot add mount point /testSpecialCharMountPointCreation/test/ > {noformat} > In the above case it should return the exist code is non zero value. > {code:java|title=RouterAdmin.java|borderStyle=solid} > Exception debugException = null; > exitCode = 0; > try { > if ("-add".equals(cmd)) { > if (addMount(argv, i)) { > System.out.println("Successfully added mount point " + argv[i]); > } > {code} > we should handle this kind of cases also. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org