[
https://issues.apache.org/jira/browse/HDDS-1713?focusedWorklogId=278990&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-278990
]
ASF GitHub Bot logged work on HDDS-1713:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/19 13:43
Start Date: 18/Jul/19 13:43
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1112: HDDS-1713.
ReplicationManager fail to find proper node topology based…
URL: https://github.com/apache/hadoop/pull/1112#issuecomment-512821424
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 83 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 7 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 32 | Maven dependency ordering for branch |
| +1 | mvninstall | 485 | trunk passed |
| +1 | compile | 251 | trunk passed |
| +1 | checkstyle | 69 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 937 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 180 | trunk passed |
| 0 | spotbugs | 393 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 637 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 37 | Maven dependency ordering for patch |
| +1 | mvninstall | 501 | the patch passed |
| +1 | compile | 266 | the patch passed |
| +1 | cc | 266 | the patch passed |
| +1 | javac | 266 | the patch passed |
| +1 | checkstyle | 78 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 738 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 163 | the patch passed |
| +1 | findbugs | 594 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 354 | hadoop-hdds in the patch failed. |
| -1 | unit | 1841 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 44 | The patch does not generate ASF License warnings. |
| | | 7490 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.hdds.scm.container.placement.algorithms.TestContainerPlacementFactory |
| | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient |
| | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures |
| | hadoop.ozone.client.rpc.TestWatchForCommit |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.om.TestKeyManagerImpl |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures |
| | hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer |
| | hadoop.ozone.TestStorageContainerManager |
| | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory |
| | hadoop.ozone.container.server.TestSecureContainerServer |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=18.09.8 Server=18.09.8 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1112/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1112 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle cc |
| uname | Linux 853d7d09bddd 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3
08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 20cf50c |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1112/4/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1112/4/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1112/4/testReport/ |
| Max. process+thread count | 5288 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service
hadoop-hdds/server-scm hadoop-ozone/integration-test hadoop-ozone/ozone-manager
U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1112/4/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 278990)
Time Spent: 2.5h (was: 2h 20m)
> ReplicationManager fail to find proper node topology based on Datanode
> details from heartbeat
> ---------------------------------------------------------------------------------------------
>
> Key: HDDS-1713
> URL: https://issues.apache.org/jira/browse/HDDS-1713
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Sammi Chen
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> DN does not have the topology info included in its heartbeat message for
> container report/pipeline report.
> SCM is where the topology information is available. During the processing of
> heartbeat, we should not rely on the datanodedetails from report to choose
> datanodes for close container. Otherwise, all the datanode locations of
> existing container replicas will fallback to /default-rack.
>
> The fix is to retrieve the corresponding datanode locations from scm
> nodemanager, which has authoritative network topology information.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
