[ https://issues.apache.org/jira/browse/HDDS-1653?focusedWorklogId=279355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279355 ]
ASF GitHub Bot logged work on HDDS-1653: ---------------------------------------- Author: ASF GitHub Bot Created on: 18/Jul/19 21:27 Start Date: 18/Jul/19 21:27 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1067: HDDS-1653. Add option to "ozone scmcli printTopology" to order the ou… URL: https://github.com/apache/hadoop/pull/1067#issuecomment-512994540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 76 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 71 | Maven dependency ordering for branch | | +1 | mvninstall | 518 | trunk passed | | +1 | compile | 315 | trunk passed | | +1 | checkstyle | 88 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 871 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 183 | trunk passed | | 0 | spotbugs | 342 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 558 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 41 | Maven dependency ordering for patch | | +1 | mvninstall | 497 | the patch passed | | +1 | compile | 321 | the patch passed | | +1 | javac | 321 | the patch passed | | +1 | checkstyle | 93 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 814 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 218 | the patch passed | | +1 | findbugs | 653 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 125 | hadoop-hdds in the patch failed. | | -1 | unit | 2095 | hadoop-ozone in the patch failed. | | +1 | asflicense | 51 | The patch does not generate ASF License warnings. | | | | 7870 | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.ozone.lock.TestLockManager | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestFailureHandlingByClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.client.rpc.TestWatchForCommit | | | hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1067/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1067 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle shellcheck shelldocs | | uname | Linux 7fc322282b06 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 9838a47 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1067/2/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1067/2/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1067/2/testReport/ | | Max. process+thread count | 4862 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/tools hadoop-ozone/dist U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1067/2/console | | versions | git=2.7.4 maven=3.3.9 shellcheck=0.4.6 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 279355) Time Spent: 50m (was: 40m) > Add option to "ozone scmcli printTopology" to order the output acccording to > topology layer > ------------------------------------------------------------------------------------------- > > Key: HDDS-1653 > URL: https://issues.apache.org/jira/browse/HDDS-1653 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Sammi Chen > Assignee: Xiaoyu Yao > Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Add option to order the output acccording to topology layer. > For example, for /rack/node topolgy, we can show, > State = HEALTHY > /default-rack: > ozone_datanode_1.ozone_default/172.18.0.3 > ozone_datanode_2.ozone_default/172.18.0.2 > ozone_datanode_3.ozone_default/172.18.0.4 > /rack1: > ozone_datanode_4.ozone_default/172.18.0.5 > ozone_datanode_5.ozone_default/172.18.0.6 > For /dc/rack/node topology, we can either show > State = HEALTHY > /default-dc/default-rack: > ozone_datanode_1.ozone_default/172.18.0.3 > ozone_datanode_2.ozone_default/172.18.0.2 > ozone_datanode_3.ozone_default/172.18.0.4 > /dc1/rack1: > ozone_datanode_4.ozone_default/172.18.0.5 > ozone_datanode_5.ozone_default/172.18.0.6 > or > State = HEALTHY > default-dc: > default-rack: > ozone_datanode_1.ozone_default/172.18.0.3 > ozone_datanode_2.ozone_default/172.18.0.2 > ozone_datanode_3.ozone_default/172.18.0.4 > dc1: > rack1: > ozone_datanode_4.ozone_default/172.18.0.5 > ozone_datanode_5.ozone_default/172.18.0.6 -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org