[
https://issues.apache.org/jira/browse/HDDS-1710?focusedWorklogId=279742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279742
]
ASF GitHub Bot logged work on HDDS-1710:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/19 13:20
Start Date: 19/Jul/19 13:20
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #994: HDDS-1710.
Publish JVM metrics via Hadoop metrics
URL: https://github.com/apache/hadoop/pull/994#issuecomment-513225921
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 61 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 23 | Maven dependency ordering for branch |
| +1 | mvninstall | 542 | trunk passed |
| +1 | compile | 272 | trunk passed |
| +1 | checkstyle | 64 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 818 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 148 | trunk passed |
| 0 | spotbugs | 330 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 540 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 31 | Maven dependency ordering for patch |
| -1 | mvninstall | 331 | hadoop-ozone in the patch failed. |
| -1 | compile | 63 | hadoop-ozone in the patch failed. |
| -1 | javac | 63 | hadoop-ozone in the patch failed. |
| -0 | checkstyle | 43 | hadoop-hdds: The patch generated 5 new + 0
unchanged - 0 fixed = 5 total (was 0) |
| -0 | checkstyle | 39 | hadoop-ozone: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 669 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 67 | hadoop-hdds generated 1 new + 14 unchanged - 0 fixed =
15 total (was 14) |
| -1 | findbugs | 108 | hadoop-ozone in the patch failed. |
||| _ Other Tests _ |
| +1 | unit | 328 | hadoop-hdds in the patch passed. |
| -1 | unit | 109 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 36 | The patch does not generate ASF License warnings. |
| | | 4960 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=18.09.8 Server=18.09.8 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/994 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 72f2d85f4faf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 4e66cb9 |
| Default Java | 1.8.0_212 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/patch-compile-hadoop-ozone.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/patch-compile-hadoop-ozone.txt
|
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/patch-findbugs-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/testReport/ |
| Max. process+thread count | 507 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service
hadoop-hdds/server-scm hadoop-ozone/ozone-manager hadoop-ozone/tools U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-994/4/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 279742)
Time Spent: 1.5h (was: 1h 20m)
> Publish JVM metrics via Hadoop metrics
> --------------------------------------
>
> Key: HDDS-1710
> URL: https://issues.apache.org/jira/browse/HDDS-1710
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: om, Ozone Datanode, SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In ozone metrics can be published with the help of hadoop metrics (for
> example via PrometheusMetricsSink)
> The basic jvm metrics are not published by the metrics system (just with JMX)
> I am very interested about the basic JVM metrics (gc count, heap memory
> usage) to identify possible problems in the test environment.
> Fortunately it's very easy to turn it on with the help of
> org.apache.hadoop.metrics2.source.JvmMetrics.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
