[
https://issues.apache.org/jira/browse/HDDS-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HDDS-1860:
--------------------------------
Description:
importContainer should use the same instantiation logic as the DataNode startup
code. It should not hard-code the KeyValueContainer classes:
{code}
KeyValueContainerData containerData =
new KeyValueContainerData(containerID,
maxSize, originPipelineId, originNodeId);
KeyValueContainer container = new KeyValueContainer(containerData,
conf);
{code}
This will break when we revision the container layout. Also sharing the
instantiation logic will save code.
was:
importContainer should use the same instantiation logic as the DataNode startup
code. It should not hard-code the KeyValueContainer classes:
{code}
KeyValueContainerData containerData =
new KeyValueContainerData(containerID,
maxSize, originPipelineId, originNodeId);
KeyValueContainer container = new KeyValueContainer(containerData,
conf);
{code}
This will break when we revision the container layout. Also making the
instantiation logic shared will save code.
> importContainer hard-codes KeyValue Container classes
> -----------------------------------------------------
>
> Key: HDDS-1860
> URL: https://issues.apache.org/jira/browse/HDDS-1860
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Arpit Agarwal
> Priority: Major
>
> importContainer should use the same instantiation logic as the DataNode
> startup code. It should not hard-code the KeyValueContainer classes:
> {code}
> KeyValueContainerData containerData =
> new KeyValueContainerData(containerID,
> maxSize, originPipelineId, originNodeId);
> KeyValueContainer container = new KeyValueContainer(containerData,
> conf);
> {code}
> This will break when we revision the container layout. Also sharing the
> instantiation logic will save code.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
