[
https://issues.apache.org/jira/browse/HDDS-1861?focusedWorklogId=283113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283113
]
ASF GitHub Bot logged work on HDDS-1861:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/19 05:29
Start Date: 26/Jul/19 05:29
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on issue #1165: HDDS-1861. Fix
TableCacheImpl cleanup logic.
URL: https://github.com/apache/hadoop/pull/1165#issuecomment-515314662
Thank you @arp7 for the review.
Test failures are not related to this patch. I will commit this to trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 283113)
Time Spent: 20m (was: 10m)
> Fix TableCacheImpl cleanup logic
> --------------------------------
>
> Key: HDDS-1861
> URL: https://issues.apache.org/jira/browse/HDDS-1861
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently in cleanup, we iterate over epochEntries and cleaup the entries
> from cache and epochEntries set.
>
> epochEntries is a TreeSet<> which is not a concurrent datastructure of java.
> We may see issue some times, when cleanup tries to remove entries and some
> other thread tries to add entries to cache. So, we need to use some
> concurrent set over there.
>
> During cluster testing, seen this some times randomly:
>
> {code:java}
> 019-07-25 15:28:41,087 WARN org.apache.hadoop.ipc.Server: IPC Server handler
> 5 on 9862, call Call#8974 Retry#0
> org.apache.hadoop.ozone.om.protocol.OzoneManagerProtocol.submitRequest from
> 10.65.15.233:35222 java.lang.NullPointerException at
> java.util.TreeMap.fixAfterInsertion(TreeMap.java:2295) at
> java.util.TreeMap.put(TreeMap.java:582) at
> java.util.TreeSet.add(TreeSet.java:255) at
> org.apache.hadoop.utils.db.cache.TableCacheImpl.put(TableCacheImpl.java:75)
> at org.apache.hadoop.utils.db.TypedTable.addCacheEntry(TypedTable.java:218)
> at
> org.apache.hadoop.ozone.om.request.key.OMKeyRequest.prepareCreateKeyResponse(OMKeyRequest.java:292)
> at
> org.apache.hadoop.ozone.om.request.key.OMKeyCreateRequest.validateAndUpdateCache(OMKeyCreateRequest.java:188)
> at
> org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB.submitRequest(OzoneManagerProtocolServerSideTranslatorPB.java:134)
> at
> org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos$OzoneManagerService$2.callBlockingMethod(OzoneManagerProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025) at
> org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876) at
> org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:822) at
> java.security.AccessController.doPrivileged(Native Method){code}
>
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2682)
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
