[
https://issues.apache.org/jira/browse/HDDS-1786?focusedWorklogId=283537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283537
]
ASF GitHub Bot logged work on HDDS-1786:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/19 18:25
Start Date: 26/Jul/19 18:25
Worklog Time Spent: 10m
Work Description: avijayanhwx commented on pull request #1163: HDDS-1786
: Datanodes takeSnapshot should delete previously created s…
URL: https://github.com/apache/hadoop/pull/1163#discussion_r307860073
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -256,6 +259,7 @@ public void persistContainerSet(OutputStream out) throws
IOException {
public long takeSnapshot() throws IOException {
TermIndex ti = getLastAppliedTermIndex();
long startTime = Time.monotonicNow();
+ SingleFileSnapshotInfo lastSnapshot = storage.findLatestSnapshot();
Review comment:
Yes, but this will change. I am planning to take up @bshashikant's
suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 283537)
Time Spent: 2h 10m (was: 2h)
> Datanodes takeSnapshot should delete previously created snapshots
> -----------------------------------------------------------------
>
> Key: HDDS-1786
> URL: https://issues.apache.org/jira/browse/HDDS-1786
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Aravindan Vijayan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Right now, after after taking a new snapshot, the previous snapshot file is
> left in the raft log directory. When a new snapshot is taken, the previous
> snapshots should be deleted.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
