[
https://issues.apache.org/jira/browse/HDDS-1856?focusedWorklogId=283720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283720
]
ASF GitHub Bot logged work on HDDS-1856:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/19 03:26
Start Date: 27/Jul/19 03:26
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1174: HDDS-1856. Make
required changes for Non-HA to use new HA code in OM.
URL: https://github.com/apache/hadoop/pull/1174#issuecomment-515647805
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 75 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 25 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 734 | trunk passed |
| +1 | compile | 361 | trunk passed |
| +1 | checkstyle | 71 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 898 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 167 | trunk passed |
| 0 | spotbugs | 434 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 632 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 574 | the patch passed |
| +1 | compile | 376 | the patch passed |
| +1 | javac | 376 | the patch passed |
| -0 | checkstyle | 41 | hadoop-ozone: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 726 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 161 | the patch passed |
| +1 | findbugs | 800 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 331 | hadoop-hdds in the patch failed. |
| -1 | unit | 2061 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 42 | The patch does not generate ASF License warnings. |
| | | 8252 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.block.TestBlockManager |
| | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures |
| | hadoop.ozone.web.client.TestBuckets |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.om.TestScmSafeMode |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1174 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux aeb69cfe5e59 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3
08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 2fe450c |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/testReport/ |
| Max. process+thread count | 4080 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 283720)
Time Spent: 1h 20m (was: 1h 10m)
> Make changes required for Non-HA to use new HA code in OM.
> ----------------------------------------------------------
>
> Key: HDDS-1856
> URL: https://issues.apache.org/jira/browse/HDDS-1856
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In this Jira following things will be implemented:
> # Make the necessary changes for non-HA code path to use Cache and
> DoubleBuffer.
> ## When adding to double buffer, return future. This future will be used in
> the non-HA path to wait for this, and when it is completed return response to
> the client.
> ## Add to double-buffer will happen inside validateAndUpdateCache. In this
> way, in non-HA, when multiple RPC handler threads are calling preExecute and
> validateAndUpdateCache, the order inserted in to double buffer will happen in
> the order requests are received.
>
> In this Jira, we shall not convert non-ha code path to use this, as security
> and acl work is not completed to use this new model.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
