[ https://issues.apache.org/jira/browse/HDDS-1619?focusedWorklogId=286420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286420 ]
ASF GitHub Bot logged work on HDDS-1619: ---------------------------------------- Author: ASF GitHub Bot Created on: 01/Aug/19 05:30 Start Date: 01/Aug/19 05:30 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #1147: HDDS-1619. Support volume acl operations for OM HA. Contributed by… URL: https://github.com/apache/hadoop/pull/1147#discussion_r309527672 ########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerHARequestHandlerImpl.java ########## @@ -70,6 +70,7 @@ public OMResponse handleApplyTransaction(OMRequest omRequest, case CreateS3Bucket: case DeleteS3Bucket: case InitiateMultiPartUpload: + case AddAcl: Review comment: Yes, But when addAcl/removeAcl/setAcl comes for bucket which is not handled, so for them we should call normal handler.handle. So, here we need to have below code ` if (omClientRequest != null) { OMClientResponse omClientResponse = omClientRequest.validateAndUpdateCache(getOzoneManager(), transactionLogIndex, ozoneManagerDoubleBuffer::add); } else { return handle(omClientRequest); }` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 286420) Time Spent: 6h (was: 5h 50m) > Support volume acl operations for OM HA. > ---------------------------------------- > > Key: HDDS-1619 > URL: https://issues.apache.org/jira/browse/HDDS-1619 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Ajay Kumar > Assignee: Xiaoyu Yao > Priority: Major > Labels: pull-request-available > Time Spent: 6h > Remaining Estimate: 0h > > [HDDS-1539] adds 4 new api for Ozone rpc client. OM HA implementation needs > to handle them. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org