[ https://issues.apache.org/jira/browse/HDFS-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898520#comment-16898520 ]
He Xiaoqiao commented on HDFS-14680: ------------------------------------ Thanks [~zhangchen] for your pings and sorry for late response since leave of absence for some days. I am have no experience about StorageInfoDefragmenter, just quick review the logic and I agree that it may `too radical` to terminate NameNode when meet any 'Throwable'/'RuntimeException'. cc [~jojochuang], I believe it is little probability to meet RuntimeException as you said above, do we need change it more elastically? Please correct me if I understand wrong. Thanks. > StorageInfoDefragmenter should handle exceptions gently > ------------------------------------------------------- > > Key: HDFS-14680 > URL: https://issues.apache.org/jira/browse/HDFS-14680 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Chen Zhang > Priority: Major > > StorageInfoDefragmenter is responsible for FoldedTreeSet compaction, but it > terminates NameNode on any exception, is it too radical? > I mean, even the critical threads like HeartbeatManager don't terminates > NameNode once they encounter exceptions, StorageInfoDefragmenter should not > do that either. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org