[
https://issues.apache.org/jira/browse/HDDS-1918?focusedWorklogId=289760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-289760
]
ASF GitHub Bot logged work on HDDS-1918:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/19 14:55
Start Date: 06/Aug/19 14:55
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1236: HDDS-1918.
hadoop-ozone-tools has integration tests run as unit
URL: https://github.com/apache/hadoop/pull/1236
## What changes were proposed in this pull request?
Run `hadoop-ozone-tools` tests as part of `integration.sh`, not `unit.sh`.
https://issues.apache.org/jira/browse/HDDS-1918
## How was this patch tested?
```
$ ./hadoop-ozone/dev-support/checks/unit.sh
...
(no Ozone Tools here)
...
$ ./hadoop-ozone/dev-support/checks/integration.sh
...
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache Hadoop Ozone Integration Tests
[jar]
[INFO] Apache Hadoop Ozone FileSystem
[jar]
[INFO] Apache Hadoop Ozone Tools
[jar]
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 289760)
Time Spent: 10m
Remaining Estimate: 0h
> hadoop-ozone-tools has integration tests run as unit
> ----------------------------------------------------
>
> Key: HDDS-1918
> URL: https://issues.apache.org/jira/browse/HDDS-1918
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build, test
> Affects Versions: 0.4.1
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HDDS-1735 created separate test runner scripts for unit and integration tests.
> Problem: {{hadoop-ozone-tools}} tests are currently run as part of the unit
> tests, but most of them start a {{MiniOzoneCluster}}, which is defined in
> {{hadoop-ozone-integration-test}}. Thus I think these tests are really
> integration tests, and should be run by {{integration.sh}} instead. There
> are currently only 3 real unit tests:
> {noformat}
> hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/audit/parser/TestAuditParser.java
> hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/freon/TestProgressBar.java
> hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/genconf/TestGenerateOzoneRequiredConfigurations.java
> {noformat}
> {{hadoop-ozone-tools}} tests take ~6 minutes.
> Possible solutions in order of increasing complexity:
> # Run {{hadoop-ozone-tools}} tests in {{integration.sh}} instead of
> {{unit.sh}} (This is similar to {{hadoop-ozone-filesystem}}, which is already
> run by {{integration.sh}} and has 2 real unit tests.)
> # Move all integration test classes to the {{hadoop-ozone-integration-test}}
> module, and make it depend on {{hadoop-ozone-tools}} and
> {{hadoop-ozone-filesystem}} instead of the other way around.
> # Rename integration test classes to {{\*IT.java}} or {{IT\*.java}}, add
> filters for Surefire runs.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
