[
https://issues.apache.org/jira/browse/HDDS-1888?focusedWorklogId=290588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290588
]
ASF GitHub Bot logged work on HDDS-1888:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 16:36
Start Date: 07/Aug/19 16:36
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1211: HDDS-1888. Add
containers to node2container map in SCM as soon as a container is created.
URL: https://github.com/apache/hadoop/pull/1211#issuecomment-519174961
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 48 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 3 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 607 | trunk passed |
| +1 | compile | 370 | trunk passed |
| +1 | checkstyle | 76 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 851 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 162 | trunk passed |
| 0 | spotbugs | 421 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 616 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 564 | the patch passed |
| +1 | compile | 372 | the patch passed |
| +1 | javac | 372 | the patch passed |
| +1 | checkstyle | 70 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 656 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 166 | the patch passed |
| +1 | findbugs | 631 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 303 | hadoop-hdds in the patch passed. |
| -1 | unit | 2105 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 53 | The patch does not generate ASF License warnings. |
| | | 7806 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider |
| | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures |
| | hadoop.ozone.client.rpc.TestWatchForCommit |
| | hadoop.ozone.om.TestScmSafeMode |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1211/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1211 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 952133fae2bc 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 70f4674 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1211/3/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1211/3/testReport/ |
| Max. process+thread count | 5009 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1211/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 290588)
Time Spent: 1.5h (was: 1h 20m)
> Add containers to node2container map in SCM as soon as a container is created
> -----------------------------------------------------------------------------
>
> Key: HDDS-1888
> URL: https://issues.apache.org/jira/browse/HDDS-1888
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In SCM node2container and node2pipeline maps are managed by NodeManager and
> pipeline2container map is managed by PipelineManager.
> Currently, when a container is allocated in SCM, it is added to
> pipeline2container map and we are not adding it to node2container map. We
> update the node2container map only when the datanode sends full container
> report.
> When a node is marked as dead, DeadNodeHandler processes the event and it
> gets the list of containers that are hosted by the dead datanode and updates
> the respective container replica state in ContainerManager. The list of
> containers on the datanode is read from node2container map, this map will be
> missing containers which are created recently (after the last container
> report). In such cases we not be able to remove the container replica
> information for those containers. In reality, these containers are under
> replicated, but SCM will never know.
> We should add containers to node2container map in SCM as soon as a container
> is allocated.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
