[
https://issues.apache.org/jira/browse/HDDS-1366?focusedWorklogId=290832&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290832
]
ASF GitHub Bot logged work on HDDS-1366:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/19 22:42
Start Date: 07/Aug/19 22:42
Worklog Time Spent: 10m
Work Description: shwetayakkali commented on pull request #1146:
HDDS-1366. Add ability in Recon to track the number of small files in an Ozone
Cluster
URL: https://github.com/apache/hadoop/pull/1146#discussion_r311792914
##########
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/FileSizeCountTask.java
##########
@@ -0,0 +1,241 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.recon.tasks;
+
+import com.google.inject.Inject;
+import org.apache.commons.lang3.tuple.ImmutablePair;
+import org.apache.commons.lang3.tuple.Pair;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.utils.db.Table;
+import org.apache.hadoop.utils.db.TableIterator;
+import org.hadoop.ozone.recon.schema.tables.daos.FileCountBySizeDao;
+import org.hadoop.ozone.recon.schema.tables.pojos.FileCountBySize;
+import org.jooq.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.List;
+
+/**
+ * Class to iterate over the OM DB and store the counts of existing/new
+ * files binned into ranges (1KB, 2Kb..,4MB,.., 1TB,..1PB) to the Recon
+ * fileSize DB.
+ */
+public class FileSizeCountTask extends ReconDBUpdateTask {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(FileSizeCountTask.class);
+
+ private int maxBinSize = -1;
+ private long maxFileSizeUpperBound = 1125899906842624L; // 1 PB
+ private long[] upperBoundCount;
+ private long oneKb = 1024L;
+ private Collection<String> tables = new ArrayList<>();
+ private FileCountBySizeDao fileCountBySizeDao;
+
+ @Inject
+ public FileSizeCountTask(OMMetadataManager omMetadataManager,
+ Configuration sqlConfiguration) {
+ super("FileSizeCountTask");
+ try {
+ tables.add(omMetadataManager.getKeyTable().getName());
+ fileCountBySizeDao = new FileCountBySizeDao(sqlConfiguration);
+ } catch (Exception e) {
+ LOG.error("Unable to fetch Key Table updates ", e);
+ }
+ upperBoundCount = new long[getMaxBinSize()];
+ }
+
+ protected long getOneKB() {
+ return oneKb;
+ }
+
+ protected long getMaxFileSizeUpperBound() {
+ return maxFileSizeUpperBound;
+ }
+
+ protected int getMaxBinSize() {
+ if (maxBinSize == -1) {
+ // extra bin to add files > 1PB.
+ maxBinSize = calculateBinIndex(maxFileSizeUpperBound) + 1;
+ }
+ return maxBinSize;
+ }
+
+ /**
+ * Read the Keys from OM snapshot DB and calculate the upper bound of
+ * File Size it belongs to.
+ *
+ * @param omMetadataManager OM Metadata instance.
+ * @return Pair
+ */
+ @Override
+ public Pair<String, Boolean> reprocess(OMMetadataManager omMetadataManager) {
+ LOG.info("Starting a 'reprocess' run of FileSizeCountTask.");
+ Table<String, OmKeyInfo> omKeyInfoTable = omMetadataManager.getKeyTable();
+ try (TableIterator<String, ? extends Table.KeyValue<String, OmKeyInfo>>
+ keyIter = omKeyInfoTable.iterator()) {
+ while (keyIter.hasNext()) {
+ Table.KeyValue<String, OmKeyInfo> kv = keyIter.next();
+ countFileSize(kv.getValue());
+ }
+ } catch (IOException ioEx) {
+ LOG.error("Unable to populate File Size Count in Recon DB. ", ioEx);
+ return new ImmutablePair<>(getTaskName(), false);
+ }
+ populateFileCountBySizeDB();
+
+ LOG.info("Completed a 'reprocess' run of FileSizeCountTask.");
+ return new ImmutablePair<>(getTaskName(), true);
+ }
+
+ @Override
+ protected Collection<String> getTaskTables() {
+ return tables;
+ }
+
+ void updateCountFromDB() {
+ // Read - Write operations to DB are in ascending order
+ // of file size upper bounds.
+ List<FileCountBySize> resultSet = fileCountBySizeDao.findAll();
+ int index = 0;
+ if (resultSet != null) {
+ for (FileCountBySize row : resultSet) {
+ upperBoundCount[index] = row.getCount();
+ index++;
+ }
+ }
+ }
+
+ /**
+ * Read the Keys from update events and update the count of files
+ * pertaining to a certain upper bound.
+ *
+ * @param events Update events - PUT/DELETE.
+ * @return Pair
+ */
+ @Override
+ Pair<String, Boolean> process(OMUpdateEventBatch events) {
+ LOG.info("Starting a 'process' run of FileSizeCountTask.");
+ Iterator<OMDBUpdateEvent> eventIterator = events.getIterator();
+
+ //update array with file size count from DB
+ updateCountFromDB();
+
+ while (eventIterator.hasNext()) {
+ OMDBUpdateEvent<String, OmKeyInfo> omdbUpdateEvent =
eventIterator.next();
+ String updatedKey = omdbUpdateEvent.getKey();
+ OmKeyInfo updatedValue = omdbUpdateEvent.getValue();
+
+ try{
+ switch (omdbUpdateEvent.getAction()) {
+ case PUT:
+ updateUpperBoundCount(updatedValue, "PUT");
+ break;
+
+ case DELETE:
+ updateUpperBoundCount(updatedValue, "DELETE");
+ break;
+
+ default: LOG.trace("Skipping DB update event : " + omdbUpdateEvent
+ .getAction());
+ }
+ } catch (IOException e) {
+ LOG.error("Unexpected exception while updating key data : {} {}",
+ updatedKey, e.getMessage());
+ return new ImmutablePair<>(getTaskName(), false);
+ }
+ populateFileCountBySizeDB();
+ }
+ LOG.info("Completed a 'process' run of FileSizeCountTask.");
+ return new ImmutablePair<>(getTaskName(), true);
+ }
+
+ /**
+ * Calculate the bin index based on size of the Key.
+ * index is calculated as the number of right shifts
+ * needed until dataSize becomes zero.
+ *
+ * @param dataSize Size of the key.
+ * @return int bin index in upperBoundCount
+ */
+ int calculateBinIndex(long dataSize) {
+ int index = 0;
+ while(dataSize != 0) {
+ dataSize >>= 1;
+ index += 1;
+ }
+ // The smallest file size being tracked for count
+ // is 1 KB i.e. 1024 = 2 ^ 10.
+ return index < 10 ? 0 : index - 10;
+ }
+
+ void countFileSize(OmKeyInfo omKeyInfo) {
+ int index;
+ if (omKeyInfo.getDataSize() >= maxFileSizeUpperBound) {
+ index = maxBinSize - 1;
+ } else {
+ index = calculateBinIndex(omKeyInfo.getDataSize());
+ }
+ upperBoundCount[index]++;
+ }
+
+ /**
+ * Populate DB with the counts of file sizes calculated
+ * using the dao.
+ *
+ */
+ void populateFileCountBySizeDB() {
+ for (int i = 0; i < upperBoundCount.length; i++) {
+ long fileSizeUpperBound = (i == upperBoundCount.length - 1) ?
+ Long.MAX_VALUE : (long) Math.pow(2, (10 + i));
+ FileCountBySize fileCountRecord =
+ fileCountBySizeDao.findById(fileSizeUpperBound);
+ FileCountBySize newRecord = new
+ FileCountBySize(fileSizeUpperBound, upperBoundCount[i]);
+ if (fileCountRecord == null) {
+ fileCountBySizeDao.insert(newRecord);
+ } else {
+ fileCountBySizeDao.update(newRecord);
+ }
+ }
+ }
+
+ private void updateUpperBoundCount(OmKeyInfo value, String operation)
+ throws IOException {
+ int binIndex = calculateBinIndex(value.getDataSize());
+ if (operation.equals("PUT")) {
+ upperBoundCount[binIndex]++;
Review comment:
handled this as part of clculateBinIndex()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 290832)
Time Spent: 9h (was: 8h 50m)
> Add ability in Recon to track the number of small files in an Ozone cluster.
> ----------------------------------------------------------------------------
>
> Key: HDDS-1366
> URL: https://issues.apache.org/jira/browse/HDDS-1366
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
> Reporter: Aravindan Vijayan
> Assignee: Shweta
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h
> Remaining Estimate: 0h
>
> Ozone users may want to track the number of small files they have in their
> cluster and where they are present. Recon can help them with the information
> by iterating the OM Key Table and dividing the keys into different buckets
> based on the data size.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
